HomeAutomation issues - HomeAutomation System
View Issue Details
0000024HomeAutomation SystemSystem, Embedded softwarepublic2012-11-05 22:012014-04-16 22:19
ReporterAnders Sandblad 
Assigned ToAnders Sandblad 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionwon't fix 
PlatformOSOS Version
Summary0000024: Warning on function StdCan_Set_class under Ubuntu 12.10
DescriptionWhen calling function StdCan_Set_class e.g. with

StdCan_Set_class(txMsg.Header, CAN_MODULE_CLASS_TST);

there is a warning when builing module:

../modules/tst_CoreLED/tst_CoreLED.c:44:2: warning: ‘txMsg.<U62f8>.Header.ClassAndDirection’ is used uninitialized in this function [-Wuninitialized]

Note there are other issues in 12.10 preventing some steps in "steps to reproduce".
Steps To Reproduce$ cd EmbeddedSoftware/AVR/personal
$ svn export template_module/ test123
$ cd test123/
$ make bios
$ ./ModuleManager --add=tst_CoreLED
$ make
TagsNo tags attached.
Attached Files

Notes
(0000035)
Anders Sandblad   
2012-11-05 22:36   
StdCan_Set_class is a macro:

#define StdCan_Set_class(Header, CLASS) Header.ClassAndDirection &= 0x01; Header.ClassAndDirection |= (CLASS << 1);

which sets the class but leaves the direction bit unchanged. It is correct that ClassAndDirection variable is uninitialized but will always be set.
(0000045)
Anders Sandblad   
2014-04-16 22:19   
Does not seem to occur in Ubuntu 13.10.

Issue History
2012-11-05 22:01Anders SandbladNew Issue
2012-11-05 22:09Anders SandbladSummaryWarning on function StdCan_Set_class => Warning on function StdCan_Set_class under Ubuntu 12.10
2012-11-05 22:36Anders SandbladNote Added: 0000035
2014-04-16 22:19Anders SandbladNote Added: 0000045
2014-04-16 22:19Anders SandbladStatusnew => resolved
2014-04-16 22:19Anders SandbladResolutionopen => won't fix
2014-04-16 22:19Anders SandbladAssigned To => Anders Sandblad